Upgrade to Node 18 #1848
Merged
Upgrade to Node 18 #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huongg <[email protected]>
…st version Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
…grade-node Signed-off-by: huongg <[email protected]>
Huongg
requested review from
rashidakanchwala,
astrojuanlu and
jitu5
as code owners
Huongg
commented
Apr 9, 2024
astrojuanlu
reviewed
Apr 10, 2024
…nd your node server don't know who to handle it. Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
1 task
ravi-kumar-pilla
approved these changes
Apr 11, 2024
astrojuanlu
reviewed
Apr 12, 2024
| "prettier": "^2.3.1", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-error-overlay": "^6.0.9", | ||
| "react-scripts": "^4.0.3", | ||
| "react-scripts": "^5.0.1", |
1 task
Signed-off-by: huongg <[email protected]>
…grade-node Signed-off-by: huongg <[email protected]>
|
Amazing work!!!!!!!!. I couldn't test it with cloud. But |
rashidakanchwala
approved these changes
Apr 15, 2024
…grade-node Signed-off-by: huongg <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1811
This ticket is to update node from version 16 (which has reached its end-of-life date) to version 18 (which has entered the long-term support)
Development notes
In order to get the app working with node 18, we also updated the following packages to new versions
QA notes
Steps to follow to test:
npm installmake buildthenmake runand make sure the app is building properlyObservation while testing it locally
It feels like the stateful URL are not working as expected since I updated Node 18 and react-script. Occasionally, clicking on a node fails to highlight it, or accessing it through the URL doesn't work as intended. Let me know if you see the same
Checklist
RELEASE.mdfilegitpod link: https://gitpod.io/new/#github.com/kedro-org/kedro-viz/pull/1848